Skip to content

fix: allow credential chain for system_history tables #19167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhang2014 merged 6 commits into from
Dec 26, 2025
Merged

fix: allow credential chain for system_history tables #19167

zhang2014 merged 6 commits into from
Dec 26, 2025

Conversation

@dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented Dec 26, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix: allow credential chain for system_history tables

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Test manually

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 26, 2025
@dqhl76 dqhl76 added the ci-cloud Build docker image for cloud test label Dec 26, 2025
@dqhl76 dqhl76 force-pushed the dqhl76/system-history-s3-403 branch from 6e46224 to ac0d629 Compare December 26, 2025 07:33
@dqhl76 dqhl76 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Dec 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2025

Docker Image for PR

  • tag: pr-19167-7490a62-1766737055

note: this image tag is only available for internal use.

@dqhl76 dqhl76 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Dec 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2025

Docker Image for PR

  • tag: pr-19167-195f343-1766742190

note: this image tag is only available for internal use.

@dqhl76
Copy link
Collaborator Author

dqhl76 commented Dec 26, 2025

test on cloud by:

select '1226162930';

SELECT    *
FROM      system_history.query_history
WHERE     query_text LIKE '%1226162930%';
image

@dqhl76 dqhl76 marked this pull request as ready for review December 26, 2025 09:52
@dqhl76 dqhl76 requested a review from zhang2014 December 26, 2025 09:52
@zhang2014 zhang2014 merged commit 1af4ff1 into databendlabs:main Dec 26, 2025
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

Assignees

No one assigned

Labels

ci-cloud Build docker image for cloud test pr-bugfix this PR patches a bug in codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dqhl76 @zhang2014